Added forward euler in python3 #203
Conversation
Gathros
added
the
Implementation
There was a problem hiding this comment.
Thanks for another contribution!
First of all, you should add a code import to euler.md or else your code won't show up at all.
{% sample lang="py" %}
### Python
[import, lang:"python"](code/python/euler.py)
Then I found a few consistency things and one actual error in your code, but nothing you won't be able to fix.
| def forward_euler(time_step, n): | ||
| result = [0] * n | ||
| result[0] = 1 | ||
| for i in range(1, n): result[i] = result[i - 1] - 3.0 * result[i - 1] * time_step |
There was a problem hiding this comment.
I'd put the loop header and the result[i] = ... statement on two separate lines.
| def forward_euler(time_step, n): | ||
| result = [0] * n | ||
| result[0] = 1 | ||
| for i in range(1, n): result[i] = result[i - 1] - 3.0 * result[i - 1] * time_step |
There was a problem hiding this comment.
Why 3.0 instead of just 3?
| return approx | ||
|
|
||
|
|
||
| time_step = 0.01 |
There was a problem hiding this comment.
Most of the Python code we have in the archive uses a main() function. To keep everything consistent, you should put this stuff inside a def main(): and call main() like, for example, in this file.
| if abs(result[i] - solution) > threshold: | ||
| print(result[i], solution) | ||
| approx = False | ||
| return approx |
There was a problem hiding this comment.
Your return statement is inside the for-loop.
|
That should do it! |
No description provided.